Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support copy keyword in __array__ method#12

Merged
asmeurer merged 2 commits into
data-apis:mainfrom
rgommers:copy-keyword
Mar 5, 2024
Merged

Support copy keyword in __array__ method#12
asmeurer merged 2 commits into
data-apis:mainfrom
rgommers:copy-keyword

Conversation

@rgommers
Copy link
Copy Markdown
Member

@rgommers rgommers commented Mar 2, 2024

Closes gh-11

@rgommers
Copy link
Copy Markdown
Member Author

rgommers commented Mar 2, 2024

The one failure is unrelated (that's the test_solve one), but it cancelled a bunch of test jobs.

@asmeurer
Copy link
Copy Markdown
Member

asmeurer commented Mar 5, 2024

Tests should be fixed by #14

@asmeurer
Copy link
Copy Markdown
Member

asmeurer commented Mar 5, 2024

Is this a change that any library that implements __array__ will have to make?

@asmeurer asmeurer enabled auto-merge March 5, 2024 22:14
@asmeurer asmeurer merged commit ab6f323 into data-apis:main Mar 5, 2024
@rgommers rgommers deleted the copy-keyword branch March 6, 2024 07:05
@rgommers
Copy link
Copy Markdown
Member Author

rgommers commented Mar 6, 2024

Is this a change that any library that implements __array__ will have to make?

Yes indeed - missing copy or dtype keywords from the __array__ signature will emit a UserWarning in 2.0, and will probably be a deprecation later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MAINT: copy semantics shim

2 participants