Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Index testing improvements #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 24, 2022
Merged

Index testing improvements #124

merged 10 commits into from
May 24, 2022

Conversation

honno
Copy link
Member

@honno honno commented May 23, 2022 •
edited
Loading

Improves test_getitem and test_setitem:

  • Test 0-sided shapes.
  • Factors out key normalisation.
  • Factors out axes_indices and out_shape inference.

Also

  • Tests all possible dtypes for test_asarray_arrays.
  • ph.assert_array() -> ph.assert_array_elements(), not caring about dtypes
  • Generally introduces more docs/comments, typing fixes, better error messages, and logic simplification.

@honno
Copy link
Member Author

honno commented May 23, 2022 •
edited
Loading

The failing test_linspace on CI looks like a flaky error on our end, will try and fix tomorrow. I'll get back to this later, see #125.

@honno honno merged commit 87834dd into data-apis:master May 24, 2022
@honno honno deleted the indexing-improvements branch February 28, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@honno