Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(pisa-proxy, sharding): add get min, max function in meta #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wbtlb merged 3 commits into from
Oct 9, 2022
Merged

feat(pisa-proxy, sharding): add get min, max function in meta #355

wbtlb merged 3 commits into from
Oct 9, 2022

Conversation

@xuanyuan300
Copy link
Contributor

@xuanyuan300 xuanyuan300 commented Oct 9, 2022 •
edited
Loading

Signed-off-by: xuanyuan300 [email protected]

What is changed and how it works?

What's Changed:

  1. Add get min, max function in meta.
  2. Fix avg_field incorrect when avg contains alias_name.
  3. Fix duplicate rewrite_outputs.
  4. Fix unit test failed.

@xuanyuan300 xuanyuan300 added app:pisa-proxy Pisa-Proxy related changes in:sharding Sharding related changes labels Oct 9, 2022
@xuanyuan300 xuanyuan300 added this to the v0.3.1 milestone Oct 9, 2022
@xuanyuan300 xuanyuan300 requested review from mlycore and wbtlb October 9, 2022 11:09
@codecov
Copy link

codecov bot commented Oct 9, 2022 •
edited
Loading

Codecov Report

Merging #355 (6656aea) into master (df61eb4) will increase coverage by 7.88%.
The diff coverage is 84.56%.

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   66.97%   74.86%   +7.88%     
==========================================
  Files           7        6       -1     
  Lines         427      716     +289     
==========================================
+ Hits          286      536     +250     
- Misses        133      169      +36     
- Partials        8       11       +3
Flag Coverage Δ
unittests 74.86% <84.56%> (+7.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/proxy/server.go 20.00% <0.00%> (-2.23%) ⬇️
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 51.35% <42.10%> (-6.55%) ⬇️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 94.62% <98.64%> (+3.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wbtlb wbtlb merged commit dfc647d into database-mesh:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbtlb wbtlb wbtlb approved these changes

@mlycore mlycore Awaiting requested review from mlycore

Assignees

@wbtlb wbtlb

Labels

app:pisa-proxy Pisa-Proxy related changes in:sharding Sharding related changes size/XL

Projects

None yet

Milestone

v0.3.1

Development

Successfully merging this pull request may close these issues.

2 participants

@xuanyuan300 @wbtlb