Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wbtlb
Copy link
Contributor

@wbtlb wbtlb commented Nov 23, 2022

What is changed and how it works?

What's Changed:

  • add pisa-controller config
  • fix error variable

@wbtlb wbtlb added the app:pisa-controller Pisa-Controller related changes label Nov 23, 2022
@wbtlb wbtlb added this to the v0.3.2 milestone Nov 23, 2022
@wbtlb wbtlb requested a review from xuanyuan300 November 23, 2022 08:11
@wbtlb wbtlb changed the title feat(pisa-controller): add database table config feat(pisa-controller): add database table strategy config Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #382 (2af41dd) into master (df61eb4) will increase coverage by 6.38%.
The diff coverage is 82.17%.

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   66.97%   73.36%   +6.38%     
==========================================
  Files           7        6       -1     
  Lines         427      732     +305     
==========================================
+ Hits          286      537     +251     
- Misses        133      184      +51     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 73.36% <82.17%> (+6.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/proxy/server.go 20.00% <0.00%> (-2.23%) ⬇️
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 51.35% <44.11%> (-6.55%) ⬇️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 90.97% <93.25%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xuanyuan300 xuanyuan300 merged commit 1dea9c1 into database-mesh:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:pisa-controller Pisa-Controller related changes size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants