refactor(sql): split type checking into CoreExpr modules#19829
Merged
Conversation
# Conflicts: # src/query/sql/src/planner/semantic/type_check.rs
# Conflicts: # src/query/sql/src/planner/semantic/type_check/sugar.rs
This reverts commit 7f46131.
sundy-li
reviewed
May 20, 2026
sundy-li
reviewed
May 20, 2026
sundy-li
requested changes
May 20, 2026
sundy-li
approved these changes
May 20, 2026
Merged
via the queue into
databendlabs:main
with commit May 20, 2026
f6c1e0c
204 of 208 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Refactor SQL type checking to lower AST expressions into CoreExpr first, then resolve them through module-specific type-check implementations. This splits the old monolithic
type_check.rs into focused modules for aggregate, scalar, special functions, UDF, column, variant, window, in-list, SRF, and related behavior.
Also narrows runtime/catalog/UDF/session dependencies behind the type-check adapter boundary, while preserving existing behavior for edge cases such as IN-list rewrite
thresholds, SRF restrictions, aggregate/window legality, UDF resolution, variant virtual columns, and vector function fallback.
Tests were reorganized to match the implementation module split and expanded with golden behavior coverage for the refactored paths.
Tests
Type of change
This change is