Update thrift library patch and prepare release
#140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Levko Kravets <[email protected]>
Signed-off-by: Levko Kravets <[email protected]>
Signed-off-by: Levko Kravets <[email protected]>
Signed-off-by: Levko Kravets <[email protected]>
susodapop
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our patch for
thriftdependency: immediately stop processing respone on HTTP error statuses (non-200), otherwise it leads to weird errors when trying to parse Thrift response body. Related to ES-662981Update to the way we ship patched
thriftdependency: Yarn 2 and upper does not respectbundledPackagesfield and completely ignores bundled dependencies. Instead, we copy patchedthriftintodist/node_modulesexplicitly. It works because Nodejs looks in nestednode_modulesfirst, and only if package not found there - will attempt to go up the directory tree. Dependencies ofthriftitself will still be located at their default locations since we still depend onthriftlibrary and it will be installed as usual.Also, with the changes mentioned above, we're going to release next library version, so all preparation steps are performed as well (update
package.json, changdelog, etc.)