Add e2e tests #12
Merged
Add e2e tests #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires the following repository secrets will be configured on GH: E2E_TEST_HOST E2E_TEST_HTTP_PATH E2E_TEST_TOKEN
moderakh
reviewed
Jun 29, 2022
| @@ -1,7 +1,7 @@ | |||
| name: Code Quality Checks | |||
| on: [push] | |||
| jobs: | |||
| run-tests: | |||
| run-unit-tests: | |||
There was a problem hiding this comment.
what does unit test mean in this context?
Is this mock unit test without the need for databricks account?
or is it integration test e2e which require databricks account
There was a problem hiding this comment.
unit means no databricks account is required.
e2e means databricks account is required.
There was a problem hiding this comment.
I'm updating the CONTRIBUTING doc with this info.
yunbodeng-db
approved these changes
Jun 29, 2022
moderakh
approved these changes
Jun 30, 2022
This reverts commit f7da497. Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
moderakh
pushed a commit
to moderakh/databricks-sql-python
that referenced
this pull request
Aug 24, 2022
Signed-off-by: Jesse Whitehouse <[email protected]> Signed-off-by: Moe Derakhshani <[email protected]>
saishreeeee
pushed a commit
that referenced
this pull request
Jun 4, 2025
Signed-off-by: Jesse Whitehouse <[email protected]>
saishreeeee
pushed a commit
that referenced
this pull request
Jun 4, 2025
Signed-off-by: Jesse Whitehouse <[email protected]> Signed-off-by: Sai Shree Pradhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description