async: replace urllib3 with httpx in THttpClient #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 25, 2023 16:24
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
rcypher-databricks
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the road to implementing async, I've added
async_thrift_http_client.pywhich began as an exact duplicate ofthrift_http_client.py. Then I replaced all calls to urllib3 with calls to httpx, but using the synchronous API. This way I can verify that our handler "speaks" the language of httpx. I then ran our e2e test suite to ensure that it works.The only failures in the e2e test were those around our custom retry policy, which I have not implemented yet.
I'll also note that proxy handling is not implemented here. And there's currently no mapping between certificates provided by users in their call to
.connect()and what is actually provided tohttpx. Those will come in follow-ups.Related tickets and documents
#176