Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Specify newer versions of numpy be used #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Specify newer versions of numpy be used #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
05ea031
Test with multiple python versions.
dbaxa Aug 15, 2022
6d130fc
Update pyarrow to version 9.0.0 to address issue in relation to pytho…
dbaxa Aug 15, 2022
2465a82
Revert "Indicate that Python 3.10 is not supported (#27)"
dbaxa Aug 15, 2022
76c34b9
Make use of numpy 1.23.2 in python >= 3.8 and use 1.21.6 in python < 3.8
dbaxa Aug 15, 2022
d7b62c5
Merge remote-tracking branch 'origin/main' into specify-newer-version…
dbaxa Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 70 additions & 31 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ include = ["CHANGELOG.md"]
[tool.poetry.dependencies]
python = "^3.7.1"
thrift = "^0.13.0"
pandas = "^1.3.0"
pandas = "^1.3.5"
numpy = [{version="^1.23.2", python=">=3.8"}, {version="^1.21.6", python="<3.8"}]
Copy link
Contributor Author

@dbaxa dbaxa Aug 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I have done what I want here. I want to specify "use at least this version of numpy for python >= 3.8". But this ends up as

{':python_version < "3.8"': ['numpy>=1.21.6,<2.0.0'],
  ':python_version >= "3.8"': ['numpy>=1.23.2,<2.0.0']}

Which is likely fine but pandas 1.3.5 for example ends up with

        numpy>=1.17.3; platform_machine!='aarch64' and platform_machine!='arm64' and python_version<'3.10'
        numpy>=1.19.2; platform_machine=='aarch64' and python_version<'3.10'
        numpy>=1.20.0; platform_machine=='arm64' and python_version<'3.10'
        numpy>=1.21.0; python_version>='3.10'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be addressed by using >=$version, but I still feel that obtaining numpy version information via pandas is better.

pyarrow = "^9.0.0"

[tool.poetry.dev-dependencies]
Expand Down