Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Introduce manual SEA test scripts for Exec Phase #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Jun 27, 2025
Merged

Introduce manual SEA test scripts for Exec Phase #589

merged 37 commits into from
Jun 27, 2025

Conversation

varun-edachali-dbx
Copy link
Collaborator

@varun-edachali-dbx varun-edachali-dbx commented Jun 9, 2025 •
edited
Loading

What type of PR is this?

  • Other - test scripts for eventual feature

Description

For the SEA implementation, before we introduce e2e tests, we introduce manual testing scripts which allow us to execute queries against a real warehouse as an implementation sanity check.

The tests are structured as follows:

sea_connector_test.py
│
├─ test_sea_session.py - tests basic session opening and closure 
│
├─ test_sea_sync_query.py - tests synchronous query execution 
│  ├─ test_sea_sync_query_with_cloud_fetch()    [use_cloud_fetch=True]
│  └─ test_sea_sync_query_without_cloud_fetch() [use_cloud_fetch=False]
│
├─ test_sea_async_query.py - tests async query execution 
│  ├─ test_sea_async_query_with_cloud_fetch()    [use_cloud_fetch=True]
│  └─ test_sea_async_query_without_cloud_fetch() [use_cloud_fetch=False]
│
└─ test_sea_metadata.py - tests metadata commands

This allows us to experiment with metadata queries, session opening and closure, synchronous queries (INLINE as well as EXTERNAL_LINKS) and async queries (INLINE as well as EXTERNAL_LINKS).

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

https://docs.google.com/document/d/1Y-eXLhNqqhrMVGnOlG8sdFrCxBTN1GdQvuKG4IfHmo0/edit?usp=sharing

@varun-edachali-dbx
[squash from exec-sea] bring over execution phase changes
138c2ae 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove excess test
3e3ab94 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
add docstring
4a78165 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remvoe exec func in sea backend
0dac4aa 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove excess files
1b794c7 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove excess models
da5a6fe 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove excess sea backend tests
686ade4 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
cleanup
31e6c83 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
re-introduce get_schema_desc
69ea238 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove SeaResultSet
66d7517 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
clean imports and attributes
71feef9 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
pass CommandId to ExecResp
ae9862f 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove changes in types
d8aa69e 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
add back essential types (ExecResponse, from_sea_state)
db139bc 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
fix fetch types
b977b12 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
excess imports
da615c0 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
reduce diff by maintaining logs
0da04a6 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
fix int test types
ea9d456 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
[squashed from exec-sea] init execution func
8985c62 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove irrelevant changes
d9bcdbe 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove ResultSetFilter functionality
ee9fa1c 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove more irrelevant changes
24c6152 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove more irrelevant changes
67fd101 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
even more irrelevant changes
271fcaf 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove sea response as init option
bf26ea3 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
exec test example scripts
ed7cf91 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx varun-edachali-dbx changed the base branch from main to sea-res-set June 9, 2025 10:09
@varun-edachali-dbx
formatting (black)
dae15e3 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx varun-edachali-dbx marked this pull request as ready for review June 11, 2025 13:31
@samikshya-db
Copy link
Contributor

Just to confirm : these tests will be replaced by the E2E tests in the future, right?

@varun-edachali-dbx
Copy link
Collaborator Author

Just to confirm : these tests will be replaced by the E2E tests in the future, right?

Yes, that's right. These scripts allow me to test the functionality against an actual warehouse before the e2e tests, which we will introduce after implementing the functionality completely.

@varun-edachali-dbx varun-edachali-dbx mentioned this pull request Jun 12, 2025
Merged
5 tasks
@varun-edachali-dbx varun-edachali-dbx mentioned this pull request Jun 18, 2025
Merged
5 tasks
jayantsing-db
jayantsing-db approved these changes Jun 27, 2025
View reviewed changes
@jayantsing-db
Copy link
Contributor

hey, why are e2e tests failing on this PR?

@varun-edachali-dbx
Copy link
Collaborator Author

varun-edachali-dbx commented Jun 27, 2025 •
edited
Loading

hey, why are e2e tests failing on this PR?

Likely flaky tests since this PR doesn't affect any code paths that the integration tests should be running. I'll let them run once again before merging.

Edit: the tests are passing

@varun-edachali-dbx varun-edachali-dbx merged commit 45585d4 into sea-migration Jun 27, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantsing-db jayantsing-db jayantsing-db approved these changes

@deeksha-db deeksha-db Awaiting requested review from deeksha-db

@samikshya-db samikshya-db Awaiting requested review from samikshya-db

@jprakash-db jprakash-db Awaiting requested review from jprakash-db

@jackyhu-db jackyhu-db Awaiting requested review from jackyhu-db

@madhav-db madhav-db Awaiting requested review from madhav-db

@gopalldb gopalldb Awaiting requested review from gopalldb

@vikrantpuppala vikrantpuppala Awaiting requested review from vikrantpuppala

@shivam2680 shivam2680 Awaiting requested review from shivam2680

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varun-edachali-dbx @samikshya-db @jayantsing-db