Complete Fetch Phase (for `INLINE` disposition and `JSON_ARRAY` format) #594

varun-edachali-dbx · 2025-06-11T08:19:36Z

What type of PR is this?

Feature

Description

Complete the Fetch phase of the SEA implementation for INLINE disposition and JSON_ARRAY format. Introduce a new JsonQueue.

Note that this is not yet feature complete, with some known failures in the following domains (for the SEA backend only):

retries
native, complex params
metadata queries

These will be resolved in future PRs.

How is this tested?

Unit tests
E2E Tests
Manually - using the test scripts invoked in examples/experimental/sea_connector_test.py.
N/A

The coverage of the key classes by the unit tests are as below:

Module	Statements	Coverage	Notes
`utils.py` (JsonQueue class)	15	100%	Completely covered
`utils.py` (SeaResultSetQueueFactory class)	20	100%	Completely covered
`result_set.py` (SeaResultSet class)	155	100%	Completely covered
`conversion.py`	43	100%	Completely covered

Related Tickets & Documents

Design Doc
PECOBLR-484

Signed-off-by: varun-edachali-dbx <[email protected]>

github-actions · 2025-07-01T05:15:23Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: varun-edachali-dbx <[email protected]>

github-actions · 2025-07-01T08:44:43Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: varun-edachali-dbx <[email protected]>

github-actions · 2025-07-02T06:52:37Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

jayantsing-db

Some minor comments. Rest LGTM.

src/databricks/sql/backend/sea/backend.py

src/databricks/sql/backend/sea/queue.py

src/databricks/sql/backend/sea/result_set.py

src/databricks/sql/utils.py

Signed-off-by: varun-edachali-dbx <[email protected]>

github-actions · 2025-07-02T08:29:36Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: varun-edachali-dbx <[email protected]>

github-actions · 2025-07-02T09:36:00Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

varun-edachali-dbx added 30 commits June 9, 2025 06:24

[squash from exec-sea] bring over execution phase changes

138c2ae

Signed-off-by: varun-edachali-dbx <[email protected]>

remove excess test

3e3ab94

Signed-off-by: varun-edachali-dbx <[email protected]>

add docstring

4a78165

Signed-off-by: varun-edachali-dbx <[email protected]>

remvoe exec func in sea backend

0dac4aa

Signed-off-by: varun-edachali-dbx <[email protected]>

remove excess files

1b794c7

Signed-off-by: varun-edachali-dbx <[email protected]>

remove excess models

da5a6fe

Signed-off-by: varun-edachali-dbx <[email protected]>

remove excess sea backend tests

686ade4

Signed-off-by: varun-edachali-dbx <[email protected]>

cleanup

31e6c83

Signed-off-by: varun-edachali-dbx <[email protected]>

re-introduce get_schema_desc

69ea238

Signed-off-by: varun-edachali-dbx <[email protected]>

remove SeaResultSet

66d7517

Signed-off-by: varun-edachali-dbx <[email protected]>

clean imports and attributes

71feef9

Signed-off-by: varun-edachali-dbx <[email protected]>

pass CommandId to ExecResp

ae9862f

Signed-off-by: varun-edachali-dbx <[email protected]>

remove changes in types

d8aa69e

Signed-off-by: varun-edachali-dbx <[email protected]>

add back essential types (ExecResponse, from_sea_state)

db139bc

Signed-off-by: varun-edachali-dbx <[email protected]>

fix fetch types

b977b12

Signed-off-by: varun-edachali-dbx <[email protected]>

excess imports

da615c0

Signed-off-by: varun-edachali-dbx <[email protected]>

reduce diff by maintaining logs

0da04a6

Signed-off-by: varun-edachali-dbx <[email protected]>

fix int test types

ea9d456

Signed-off-by: varun-edachali-dbx <[email protected]>

[squashed from exec-sea] init execution func

8985c62

Signed-off-by: varun-edachali-dbx <[email protected]>

remove irrelevant changes

d9bcdbe

Signed-off-by: varun-edachali-dbx <[email protected]>

remove ResultSetFilter functionality

ee9fa1c

Signed-off-by: varun-edachali-dbx <[email protected]>

remove more irrelevant changes

24c6152

Signed-off-by: varun-edachali-dbx <[email protected]>

remove more irrelevant changes

67fd101

Signed-off-by: varun-edachali-dbx <[email protected]>

even more irrelevant changes

271fcaf

Signed-off-by: varun-edachali-dbx <[email protected]>

remove sea response as init option

bf26ea3

Signed-off-by: varun-edachali-dbx <[email protected]>

exec test example scripts

ed7cf91

Signed-off-by: varun-edachali-dbx <[email protected]>

formatting (black)

dae15e3

Signed-off-by: varun-edachali-dbx <[email protected]>

[squashed from sea-exec] merge sea stuffs

db5bbea

Signed-off-by: varun-edachali-dbx <[email protected]>

remove excess changes

d5d3699

Signed-off-by: varun-edachali-dbx <[email protected]>

remove excess removed docstring

6137a3d

Signed-off-by: varun-edachali-dbx <[email protected]>

databricks deleted a comment from github-actions bot Jul 1, 2025

correct docstrings, ProgrammingError -> ValueError

c21ff5e

Signed-off-by: varun-edachali-dbx <[email protected]>

varun-edachali-dbx had a problem deploying to azure-prod July 1, 2025 05:15 — with GitHub Actions Failure

let type of rows by List[List[str]] for clarity

72100b9

Signed-off-by: varun-edachali-dbx <[email protected]>

varun-edachali-dbx had a problem deploying to azure-prod July 1, 2025 08:44 — with GitHub Actions Failure

varun-edachali-dbx had a problem deploying to azure-prod July 1, 2025 12:24 — with GitHub Actions Failure

varun-edachali-dbx added 2 commits July 2, 2025 06:51

select Queue based on format in manifest

aab33a1

Signed-off-by: varun-edachali-dbx <[email protected]>

make manifest mandatory

9a6db30

Signed-off-by: varun-edachali-dbx <[email protected]>

varun-edachali-dbx had a problem deploying to azure-prod July 2, 2025 06:52 — with GitHub Actions Failure

jayantsing-db approved these changes Jul 2, 2025

View reviewed changes

stronger type checking in JSON helper functions in Sea Result Set

0135d33

Signed-off-by: varun-edachali-dbx <[email protected]>

varun-edachali-dbx had a problem deploying to azure-prod July 2, 2025 08:29 — with GitHub Actions Failure

assign empty array to data array if None

cc9db8b

Signed-off-by: varun-edachali-dbx <[email protected]>

varun-edachali-dbx temporarily deployed to azure-prod July 2, 2025 09:17 — with GitHub Actions Inactive

stronger typing in JsonQueue

bb135fc

Signed-off-by: varun-edachali-dbx <[email protected]>

databricks deleted a comment from github-actions bot Jul 2, 2025

varun-edachali-dbx temporarily deployed to azure-prod July 2, 2025 09:35 — with GitHub Actions Inactive

varun-edachali-dbx merged commit 70c7dc8 into sea-migration Jul 2, 2025
22 of 23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Complete Fetch Phase (for `INLINE` disposition and `JSON_ARRAY` format) #594

Complete Fetch Phase (for `INLINE` disposition and `JSON_ARRAY` format) #594

varun-edachali-dbx commented Jun 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

jayantsing-db left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

Uh oh!

Uh oh!

Complete Fetch Phase (for INLINE disposition and JSON_ARRAY format) #594

Complete Fetch Phase (for INLINE disposition and JSON_ARRAY format) #594

Conversation

varun-edachali-dbx commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

Description

How is this tested?

Related Tickets & Documents

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

jayantsing-db left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

Uh oh!

Uh oh!

Complete Fetch Phase (for `INLINE` disposition and `JSON_ARRAY` format) #594

Complete Fetch Phase (for `INLINE` disposition and `JSON_ARRAY` format) #594

varun-edachali-dbx commented Jun 11, 2025 •

edited

Loading