Merge SeaHttpClient into THttpClient
#603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeaHttpClient with THttpClientSeaHttpClient into THttpClient
2c355ef to
146187c
Compare
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 86968f3. Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 0034d46. Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 08827ef. Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 3e281eb. Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 6a14a72. Signed-off-by: varun-edachali-dbx <[email protected]>
d4870c5 to
6bf5995
Compare
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 00fc119.
Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit f3bc8a0.
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: varun-edachali-dbx <[email protected]>
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Superseded by #618. Decided to create a new, separate HTTP Client for SEA rather than merging into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Currently, the
SeaDatabricksClientuses a simpleSeaHttpClient, which helped us introduce SEA features in isolation without having to worry about the HTTP Client details.To allow the re-use of implemented auth and efficiency features in the
THttpClient, we aim to re-use it in the SEA client and eliminate the oldSeaHttpClient.How is this tested?
INLINEdisposition andJSON_ARRAYformat) #594The coverage of the newly introduced methods in
THttpClientbytest_thrift_http_client.pyis as below:thrift_http_client.pymake_rest_request- Line 321: Logging truncated response content
thrift_http_client.py_check_rest_response_for_errorRelated Tickets & Documents
https://docs.google.com/document/d/1Y-eXLhNqqhrMVGnOlG8sdFrCxBTN1GdQvuKG4IfHmo0/edit?usp=sharing