Testing for telemetry #616
Conversation
Signed-off-by: Sai Shree Pradhan <[email protected]>
|
|
||
|
|
||
| class TestTelemetryRaceConditions: |
There was a problem hiding this comment.
should we add these in a separate file? @jprakash-db what's the sop in python?
| thread.join() | ||
|
|
||
| assert len(operation_results) == 15 |
There was a problem hiding this comment.
i think we should have some tests where there are concurrently threads executing queries and the telemetry is being captured correctly, is that possible to do?
| assert isinstance(client, NoopTelemetryClient) | ||
|
|
||
| def test_telemetry_client_factory_mixed_concurrent_operations(self, race_condition_setup): |
There was a problem hiding this comment.
do we need to have separate tests for this i.e. concurrent_init, concurrent_get, concurrent_flush etc? can we not simply have a larger thread pool and just do all of these in a single test?
There was a problem hiding this comment.
Keeping separate tests helps in finding which operation specifically is causing the race condition. The test_telemetry_client_factory_mixed_concurrent_operations tests the mixed-operation scenario which is more realistic. So both scenarios (focused on a particular operation and the mixed one) are covered.
Signed-off-by: Sai Shree Pradhan <[email protected]>
What type of PR is this?
Description
Added multithread tests, exception handling tests
How is this tested?
Related Tickets & Documents
PECOBLR-584