Add retry mechanism to telemetry requests #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Adds a retry mechanism to telemetry requests by integrating a custom HTTP adapter and retry policy, updates client methods to use a session with retries, and adjusts tests accordingly.
- Introduce TelemetryHTTPAdapter to apply DatabricksRetryPolicy before each request
- Update TelemetryClient to use requests.Session with mounted retry adapter and replace direct requests.post
- Adjust unit and E2E tests to mock Session.post and verify retry behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/unit/test_telemetry.py | Updated mocks and assertions to patch and verify Session.post calls |
| tests/e2e/test_telemetry_retry.py | New E2E tests for retry scenarios, mocking HTTPSConnectionPool |
| src/databricks/sql/telemetry/telemetry_client.py | Added TelemetryHTTPAdapter, retry policy setup, session usage, session close, and log level tweak for uninitialized client |
| src/databricks/sql/exc.py | Removed top‐level telemetry import and added a lazy import inside the constructor |
Comments suppressed due to low confidence (2)
src/databricks/sql/telemetry/telemetry_client.py:438
- The fallback log when the client isn’t initialized is set to debug, which may suppress important errors; consider using warning level to surface misconfiguration.
logger.debug(
src/databricks/sql/telemetry/telemetry_client.py:203
- [nitpick] Currently the retry adapter is only mounted for HTTPS; if future tests or endpoints use HTTP, consider mounting on "http://" as well to ensure consistency.
self._session.mount("https://", adapter)
Signed-off-by: Sai Shree Pradhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Retry mechanism for telemetry requests
How is this tested?
Related Tickets & Documents
PECOBLR-586