Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enhance SEA HTTP Client #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: ext-links-sea
Choose a base branch
from
+302 −101
Draft

Enhance SEA HTTP Client #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
11bc165
preliminary (robust) SEA HTTP Client
varun-edachali-dbx Jun 27, 2025
d389316
prevent catching of MaxRetryError and HttpError in client
varun-edachali-dbx Jun 27, 2025
cc48caf
formatting (black)
varun-edachali-dbx Jun 27, 2025
6a1274f
fix type annotations
varun-edachali-dbx Jun 27, 2025
ebc1915
Merge branch 'ext-links-sea' into sea-http-client
varun-edachali-dbx Jun 27, 2025
4651cd6
pass test_retry_exponential_backoff
varun-edachali-dbx Jun 30, 2025
d67eb7b
prevent parsing empty response data (get test_retry_abort_non_recover…
varun-edachali-dbx Jun 30, 2025
2caf38d
more defensive parsing, allow more method types in urllib3
varun-edachali-dbx Jun 30, 2025
3e55ddd
allow Any values in session_conf, cast to String as done in Thrift ba…
varun-edachali-dbx Jun 30, 2025
4afff39
account for max_redirects in SEA backend
varun-edachali-dbx Jun 30, 2025
01d49cd
return empty JsonQueue if no data
varun-edachali-dbx Jul 1, 2025
3d8aa7f
do not preload content?
varun-edachali-dbx Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/databricks/sql/auth/retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ def __init__(
allowed_methods=["POST"],
status_forcelist=[429, 503, *self.force_dangerous_codes],
)

urllib3_kwargs.update(**_urllib_kwargs_we_care_about)
_urllib_kwargs_we_care_about.update(**urllib3_kwargs)
urllib3_kwargs = _urllib_kwargs_we_care_about

super().__init__(
**urllib3_kwargs,
Expand Down
8 changes: 4 additions & 4 deletions src/databricks/sql/backend/sea/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import logging
import time
import re
from typing import Dict, Tuple, List, Optional, Union, TYPE_CHECKING, Set
from typing import Any, Dict, Tuple, List, Optional, Union, TYPE_CHECKING, Set

from databricks.sql.backend.sea.models.base import ExternalLink, ResultManifest
from databricks.sql.backend.sea.utils.constants import (
Expand Down Expand Up @@ -49,7 +49,7 @@


def _filter_session_configuration(
session_configuration: Optional[Dict[str, str]]
session_configuration: Optional[Dict[str, Any]]
) -> Optional[Dict[str, str]]:
if not session_configuration:
return None
Expand All @@ -59,7 +59,7 @@ def _filter_session_configuration(

for key, value in session_configuration.items():
if key.upper() in ALLOWED_SESSION_CONF_TO_DEFAULT_VALUES_MAP:
filtered_session_configuration[key.lower()] = value
filtered_session_configuration[key.lower()] = str(value)
else:
ignored_configs.add(key)

Expand Down Expand Up @@ -183,7 +183,7 @@ def max_download_threads(self) -> int:

def open_session(
self,
session_configuration: Optional[Dict[str, str]],
session_configuration: Optional[Dict[str, Any]],
catalog: Optional[str],
schema: Optional[str],
) -> SessionId:
Expand Down
Loading
Loading