Fix potential resource leak in CloudFetchQueue
#624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: varun-edachali-dbx <[email protected]>
…gardless of server side state Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
samikshya-db
approved these changes
Jul 4, 2025
jprakash-db
reviewed
Jul 8, 2025
| @@ -1509,6 +1509,7 @@ def close(self) -> None: | |||
| if isinstance(e.args[1], CursorAlreadyClosedError): | |||
| logger.info("Operation was canceled by a prior request") | |||
| finally: | |||
| self.results.close() | |||
There was a problem hiding this comment.
nit: Can you move the self.results.close(), within the try block. - Logical step will be first close the resultSet and then close the command on the server. Secondly don't want any error in the finally part, this will lead to op_state variables in unset state
jprakash-db
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
The
ResultFileDownloadManagerin theCloudFetchQueueis not shut down alongside theResultSet.The
ResultFileDownloadManageron being requested for a file ensures that the "download queue is always full", i.e. it adds uptomax_download_threadsFutures into_download_tasks. In caseResultSet.close()is invoked after this,_shutdown_manager(defined forResultFileDownloadManager) is NOT called, so these Futures keep executing in the background and the files keep being downloaded.We define a
closefor theCloudFetchQueuethat invokes_shutdown_manager.How is this tested?
Related Tickets & Documents
N/A