Clean up setup.py#128
Merged
Merged
Conversation
mvpatel2000
approved these changes
Jul 31, 2024
mvpatel2000
left a comment
Contributor
There was a problem hiding this comment.
LGTM, didn't read setup too closely. Assuming copy pasted from composer?
Contributor
Author
|
Yep, copy and pasted from Composer! |
mihir-db
reviewed
Aug 1, 2024
mihir-db
left a comment
Contributor
There was a problem hiding this comment.
Approved with wrong account
mihir-db
approved these changes
Aug 1, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up
setup.pybased on Composer'ssetup.pyand is a follow up after #127. This is a better organized version of #126 as many of the changes made in #126 were already made in #127.Specifically, this PR:
torchwhile runningsetup.py_version.pyfile__init__.pyfile to MegaBlocksREADME.mdbetter for the pypi descriptionThese changes pass all the tests on the Github Action on my local fork: https://github.com/eitanturok/megablocks/actions/runs/10183100358. It currently seems like there are issues with the GAs here.
In a separate PR we will update the package owner name and email. (Still waiting on Kobie to get back to me about this.)