GA to Lint + Format MegaBlocks#131
Merged
Merged
Conversation
added 18 commits
July 31, 2024 17:02
6 tasks
added 3 commits
August 1, 2024 19:26
Contributor
Author
|
I addressed all of your comments @b-chu except for taking care of fixing the All the tests pass, so it seems like this isn't such a bad issue... |
b-chu
suggested changes
Aug 7, 2024
b-chu
left a comment
Contributor
There was a problem hiding this comment.
Fix the init files. Names should definitely match
Contributor
Author
|
I also added a contributing guide, style guide, and Pull_REQUEST template, all initially taken from composer. |
mvpatel2000
reviewed
Aug 8, 2024
mvpatel2000
left a comment
Contributor
There was a problem hiding this comment.
can you change license to Databricks? Otherwise LGTM, would also like @b-chu to approve since large PR
Co-authored-by: Mihir Patel <[email protected]>
…blocks into eitan-pre-commit
added 3 commits
August 8, 2024 19:55
Contributor
Author
|
@mihir-db I changed the license. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lints and formats MegaBlocks. Specifically, we:
.pre-commit-config.yamlwith all of the same hooks as composer except forpyright(will be done in a subsequent PR).pre-commithooks. Changes includeNote: I made all the
.shfiles in theexpdirectory executable as per thecheck-executables-have-shebangshook.