Enable generic dimentionality for input#41
Merged
Conversation
mvpatel2000
approved these changes
Dec 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MegaBlocks currently assumes a 3D input
[sl, bs, hs]when in fact MegaBlocks should be able to operate on inputs of any multi-dim shape[*, hs]The changes in this PR enable that.
Useful for padded inputs. If we flatten padded inputs with shape:
[sl, bs, hs]into input with shape:[sl * bs - num_pad_tok, hs], then pad tokens are not part of all2all routing and lbl isn't computed on padding tokens.