Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update dependencies and package organization.#52

Merged
tgale96 merged 3 commits into
mainfrom
install-update
Dec 11, 2023
Merged

Update dependencies and package organization.#52
tgale96 merged 3 commits into
mainfrom
install-update

Conversation

@tgale96

@tgale96 tgale96 commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

No description provided.

…dencies. Update recommended Docker container. Make GroupedMLP tests conditional on package availability.
Comment thread setup.py
'stanford-stk @ git+https://github.com/stanford-futuredata/stk.git@main',
'grouped_gemm @ git+https://github.com/tgale96/grouped_gemm@main',
'mosaicml-turbo==0.0.4',
"triton==2.1.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need strict pin? Might cause problems down the road if someone else (eg torch) starts upgrading....

Could we lower bound?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about Triton breaking us with a newer release. We could make it >=2.1.0, but that's a little risky.

Comment thread setup.py Outdated
extra_deps['dev'] = [
'absl-py',
extra_deps["gg"] = [
"grouped_gemm @ git+https://github.com/tgale96/grouped_gemm@main",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a tagged version instead of main branch

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm moving this package onto PyPi so we can push the new megablocks packages.

Comment thread setup.py
]

extra_deps["quant"] = [
"mosaicml-turbo==0.0.4",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"mosaicml-turbo==0.0.4",
"mosaicml-turbo==0.0.5",

@dblalock can we bump to 0.0.5?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this in a separate PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I'd rather not touch anything right now

@tgale96 tgale96 merged commit 409686e into main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants