Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Internal/fix failing Clarin integration test #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 14 commits into from
Oct 31, 2024
Merged

Internal/fix failing Clarin integration test #796

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ef0da86
Initial commit
milanmajchrak Oct 29, 2024
bb5308f
Ignore the test class from where the tests has started failing.
milanmajchrak Oct 30, 2024
fc27ab2
Ignored half of tests in the ClarinShibbolethLoginFilterIT file
milanmajchrak Oct 30, 2024
e9e6988
Ignored all tests
milanmajchrak Oct 30, 2024
293a621
Ade
milanmajchrak Oct 30, 2024
055de65
unignore some tests
milanmajchrak Oct 30, 2024
0b9c0ca
3 tests ignored 3 allowed
milanmajchrak Oct 30, 2024
0de9b87
Maybe the problematic test is hidden between 3 unignored tests
milanmajchrak Oct 30, 2024
933e048
two candidates
milanmajchrak Oct 30, 2024
817aa74
The last candidate
milanmajchrak Oct 30, 2024
8357ca2
Ignore just wrong test and all test should pass
milanmajchrak Oct 30, 2024
4128753
Clean up object created in the test.
milanmajchrak Oct 31, 2024
dba9f70
Removed unused import.
milanmajchrak Oct 31, 2024
f5118c6
Check the user which is going to be deleted is not null.
milanmajchrak Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...rver-webapp/src/test/java/org/dspace/app/rest/security/ClarinShibbolethLoginFilterIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,9 @@ public void testShouldReturnDuplicateUserErrorLoginWithoutNetId() throws Excepti
.andExpect(redirectedUrl("http://localhost:4000/login/duplicate-user?email=" + email))
.andReturn().getResponse().getHeader("Authorization");

// Check if was created a user with such email and netid.
EPerson ePerson = checkUserWasCreated(netId, IDP_TEST_EPERSON, email, null);
deleteShibbolethUser(ePerson);
Copy link
Collaborator

@Paurikova2 Paurikova2 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats about if ePerson is null?

}

// This test is copied from the `ShibbolethLoginFilterIT` and modified following the Clarin updates.
Expand Down Expand Up @@ -567,6 +570,7 @@ public void testSuccessFullLoginWithTwoEmails() throws Exception {
checkUserIsSignedIn(token);
// Find the user by the second email
EPerson ePerson = checkUserWasCreated(null, IDP_TEST_EPERSON, secondEmail, null);
assertTrue(Objects.nonNull(ePerson));
deleteShibbolethUser(ePerson);
}

Expand Down