UFAL/Preview - fixed loading files #824

milanmajchrak · 2025-04-03T15:10:34Z

Phases	MP	MM	MB	MR	JM
ETA	0	0	0	0	0
Developing	0	0	0	0	0
Review	0	0	0	0	0
Total	-	-	-	-	-
ETA est.
ETA cust.	-	-	-	-	-

Problem description

Show loading icon when loading the files information with the preview. There is also a link to contact the administrator when it took so long.
Show an message when the file preview is not generated because of some error.

Summary by CodeRabbit

New Features
- Improved search functionality with streamlined input handling.
- Enhanced table layout for better responsiveness across device sizes.
- Refined file preview experience featuring a loading spinner and a support contact option when previews cannot be generated.
- Updated user messages for file loading and preview issues in both English and Czech.
Tests
- Updated test configurations to support the new translation and configuration data handling.

…ponsiveness across browsers

…ondition

… administrator when it took so long

coderabbitai · 2025-04-03T15:10:41Z

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update search functionality in the HandleTable component by replacing one-way binding with two-way binding for the search input, removing direct DOM references, and enhancing observable management for pagination and sorting. In the preview-related components, conditional rendering is refined to show a loading spinner when data is missing, and a configuration service is integrated to retrieve a contact email. Additionally, tests are updated with new translation modules and mocks, and new translation entries have been added in both Czech and English.

Changes

File(s)	Change Summary
`src/app/handle-page/handle-table/handle-table.component.{html,ts}`	Updated search input to use two-way binding; removed template reference and direct DOM manipulation; streamlined observable pipeline with a BehaviorSubject; added helper methods for retrieving pagination and sort settings; added responsive table class.
`src/app/item-page/simple/field-components/preview-section/file-description/file-description.component.{html,ts}`	Refactored conditional rendering to check for file content presence; introduced loading spinner; replaced explicit format checks with an `isArchive` method; implemented `OnInit` lifecycle for subscribing to configuration data; updated constructor to inject ConfigurationDataService.
`src/app/item-page/simple/field-components/preview-section/preview-section.component.{html,ts,spec.ts}`	Introduced a loading spinner for empty file lists; updated component to retrieve and store a contact email via ConfigurationDataService; adjusted constructor and tests to include translation modules and configuration service mocks.
`src/assets/i18n/{cs,en}.json5`	Added new translation entries for file preview loading and error messages in both Czech and English.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant HT as HandleTableComponent
  participant Obs as Search Observable Pipeline
  participant API as Backend Service
  U->>HT: Enter search query (via ngModel)
  HT->>Obs: Update searchTerm BehaviorSubject
  Obs->>API: Request handles using current search term, pagination, and sort options
  API-->>Obs: Return filtered handles data
  Obs-->>HT: Emit updated handle list

sequenceDiagram
  participant C as PreviewSection/FileDescription Component
  participant CS as ConfigurationDataService
  participant T as Template
  C->>CS: ngOnInit() → findByPropertyName('lr.help.mail')
  CS-->>C: Return contact email data
  C->>T: Bind emailToContact for mailto link display

Poem

Oh, I'm a bunny with a hop and a beat,
Enhancements in code make my heart skip a beat.
Search inputs dance with two-way grace,
Spinners and emails now find their place.
I munch on carrots as bugs take flight,
Celebrating changes from morning to night.
🥕 Happy coding, hop along bright!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "22.9.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 654611d and 0028272.

📒 Files selected for processing (9)

src/app/handle-page/handle-table/handle-table.component.html (1 hunks)
src/app/handle-page/handle-table/handle-table.component.ts (4 hunks)
src/app/item-page/simple/field-components/preview-section/file-description/file-description.component.html (1 hunks)
src/app/item-page/simple/field-components/preview-section/file-description/file-description.component.ts (2 hunks)
src/app/item-page/simple/field-components/preview-section/preview-section.component.html (1 hunks)
src/app/item-page/simple/field-components/preview-section/preview-section.component.spec.ts (1 hunks)
src/app/item-page/simple/field-components/preview-section/preview-section.component.ts (3 hunks)
src/assets/i18n/cs.json5 (1 hunks)
src/assets/i18n/en.json5 (1 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

milanmajchrak · 2025-04-03T15:13:18Z

#825

milanmajchrak added 4 commits March 31, 2025 18:29

Fixed table responsivity and searching

052f4ff

Move table-responsive to div because it ensures more consistent res…

8a5f881

…ponsiveness across browsers

Use combineLatest because it is more common for RxJS, refactor if c…

ecb7ca5

…ondition

Show loading icon when loading the files with a asking to contant the…

0028272

… administrator when it took so long

milanmajchrak self-assigned this Apr 3, 2025

milanmajchrak closed this Apr 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

UFAL/Preview - fixed loading files #824

UFAL/Preview - fixed loading files #824

Uh oh!

milanmajchrak commented Apr 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 3, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

milanmajchrak commented Apr 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

UFAL/Preview - fixed loading files #824

UFAL/Preview - fixed loading files #824

Uh oh!

Conversation

milanmajchrak commented Apr 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem description

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

milanmajchrak commented Apr 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

milanmajchrak commented Apr 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)