Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ufal/seznam license request #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
milanmajchrak merged 7 commits into from
May 7, 2025
Merged

Ufal/seznam license request #844

milanmajchrak merged 7 commits into from
May 7, 2025

Conversation

@jr-rk
Copy link

@jr-rk jr-rk commented Apr 24, 2025 •
edited by coderabbitai bot
Loading

…nses

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

Request for szn-dataset-license.html was sent even when the license (which needs agreement) was different (for example Hamledt 3.0)

Summary by CodeRabbit

  • Bug Fixes
    • Improved license content loading to display the Seznam dataset license only when applicable, based on item metadata.

@jr-rk jr-rk self-assigned this Apr 24, 2025
@coderabbitai
Copy link

coderabbitai bot commented Apr 24, 2025 •
edited
Loading

"""

Walkthrough

The method loadLicenseContentSeznam() was changed to subscribe to the item$ BehaviorSubject and load the Seznam license content only when the first dc.rights metadata value matches the constant LICENSE_NAME_SEZNAM. The license content is fetched asynchronously inside the subscription, and the method no longer returns a value.

Changes

File(s) Change Summary
src/app/bitstream-page/clarin-license-agreement-page/clarin-license-agreement-page.component.ts Modified loadLicenseContentSeznam() to subscribe to item$ and conditionally fetch Seznam license content based on metadata. Removed return value from the method.

Poem

A bunny hopped into some code,
Where licenses once always showed.
Now it waits, with patient flair,
For the rights to match—if they're there!
Only then, with careful delight,
The Seznam license comes to light.
🐇✨
"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "22.9.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3430be6 and 71ecf7d.

📒 Files selected for processing (1)
  • src/app/bitstream-page/clarin-license-agreement-page/clarin-license-agreement-page.component.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/app/bitstream-page/clarin-license-agreement-page/clarin-license-agreement-page.component.ts
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: dspace-angular / docker-build (linux/amd64, ubuntu-latest, true)
  • GitHub Check: tests (18.x)
  • GitHub Check: tests (16.x)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jr-rk jr-rk linked an issue Apr 24, 2025 that may be closed by this pull request
UFAL/Szn license text always downloaded #830
Closed
@jr-rk jr-rk requested a review from milanmajchrak April 24, 2025 14:19
@jr-rk jr-rk requested a review from milanmajchrak May 6, 2025 13:42
@jr-rk jr-rk requested a review from milanmajchrak May 7, 2025 09:24
@milanmajchrak
Copy link
Collaborator

milanmajchrak commented May 7, 2025

Please also add it into UI manual tests

@milanmajchrak milanmajchrak merged commit 40c8fb8 into dtq-dev May 7, 2025
6 checks passed
@kosarko kosarko mentioned this pull request May 20, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jun 3, 2025
Merged
@kosarko kosarko mentioned this pull request Jun 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milanmajchrak milanmajchrak Awaiting requested review from milanmajchrak

Assignees

@jr-rk jr-rk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UFAL/Szn license text always downloaded

3 participants

@jr-rk @milanmajchrak