LINDAT/Refactored workflows #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors GitHub Actions workflows by removing duplicate functionality and consolidating test execution. The changes eliminate duplicate build and UI test trigger workflows that were redundant with similar functionality in the dtq-dev repository.
- Removed duplicate workflow files for triggering builds and UI tests across customer branches
- Refactored deploy workflow to use reusable workflow calls instead of inline job definitions
- Consolidated Playwright test execution by referencing a shared workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/trigger-ui-tests.yml | Completely removed duplicate workflow for triggering UI tests across customer branches |
| .github/workflows/trigger-builds.yml | Completely removed duplicate workflow for triggering builds across customer branches |
| .github/workflows/deploy.yml | Refactored to use reusable workflow calls for Playwright tests instead of inline job definitions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Reported issues
Not-reported issues
Analysis
Problems
There was duplicity in workflows and triggers for ui tests and builds, which are only triggered from dtq-dev. so they are not necessary here.