Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Why require scales to be integers? #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erickreutz opened this issue Sep 1, 2022 · 3 comments
Closed

Why require scales to be integers? #11

erickreutz opened this issue Sep 1, 2022 · 3 comments
Assignees
@davidhellmann
Labels
enhancement New feature or request

Comments

@erickreutz
Copy link

erickreutz commented Sep 1, 2022 •
edited
Loading

I see you are doing checks to see whether the values are integers and if they are - returning the value instead of calculating the modular scale. Why is this? Would be nice to have x.5 scales or any arbitrary scale. If I submitted a PR would you accept it?
@davidhellmann
Copy link
Owner

Hey @erickreutz

It's simple because the modular scale is a harmonic way to define your fonts.
With float numbers, you kill that harmony. But I think you're not interested in that modular scale thing and you just like to use fluid type, right?

But I think it's easy to implement. I'll look into it after my vacation and combine it with the V2 launch.
If there is a reason to not do it I'll let you know here.

Thanks!

@davidhellmann davidhellmann self-assigned this Sep 1, 2022
@davidhellmann davidhellmann added the enhancement New feature or request label Sep 1, 2022
davidhellmann added a commit that referenced this issue Oct 6, 2022
@davidhellmann
🎨 chore: check just for number not for integer #11
e2dc055
@davidhellmann
Copy link
Owner

@erickreutz haven't test it for now because I'm positive atm and not really working. But maybe you can check it / play with it: https://github.com/davidhellmann/tailwindcss-fluid-type/releases/tag/v2.0.0-alpha.4

@davidhellmann
Copy link
Owner

v2 is released with these changes: https://github.com/davidhellmann/tailwindcss-fluid-type/releases/tag/2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhellmann davidhellmann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erickreutz @davidhellmann