feat: Update to Angular 14 #44
Conversation
- Expose additional components due to Typescript requirement. - Minor doco updates. - Build pipeline bump to Node16 (from 14)
There was a problem hiding this comment.
Thanks again for your work @jafin. It's much appreciated.
At work I'm still using an Angular version < 14, so I've not yet familiarised myself with the details of typed forms. At the moment your PR modifies the code such that it works with untyped forms.
I don't know if this would already work with typed forms? If so, then we might want to consider adding some tests for it. If not, and the changes necessary to make it work are minor, then we might want to consider supporting it within this PR. If typed forms requires more changes, then we'll just release this and consider it a separate feature. In that case we might want to put a warning in the documentation that only untyped forms are supported at the moment.
|
|
||
| export const getFormControlFromContainer = (name: string, controlContainer: ControlContainer | undefined): FormControl => { | ||
| export const getFormControlFromContainer = (name: string, controlContainer: ControlContainer | undefined): UntypedFormControl => { |
There was a problem hiding this comment.
I suppose we want to support typed forms as well? I'm not sure if this change handles both typed and untyped forms. It might be a good idea to add some typed form tests and check.
The Angular documentation lists an UntypedFormControl as an alias for FormControl<any>, but I'm not sure what the runtime behaviour of it all would be.
There was a problem hiding this comment.
I don't have the knowledge on this one at the moment, I honestly just did the bare minimum for the upgrade and my understanding was that the untyped maintained compatibility without any changes. Additional tests would be good yes.
There was a problem hiding this comment.
In src\app\app.component.ts I changed UntypedFormBuilder to FormBuilder. This still works fine.
I suspect this is what happens:
typeis a TypeScript construct which needs to be compiled away. Thustype UntypedFormControl = FormControl<any>;becomesFormControl<any>.- Generics are also a TypeScript construct which needs to be compiled away. Thus
FormControl<any>becomesFormControl. - A typed form control would have say type
FormControl<string | null>, which then would also becomeFormControl.
Thus a line like if (!(control instanceof UntypedFormControl)) { actually compiles to if (!(control instanceof FormControl)) {.
I'll release a new version somewhere later today or tomorrow.
| }]; | ||
|
|
||
| combinations.forEach(combination => { | ||
| combination.controls.forEach(control => { | ||
| const nativeResult = combination.nativeValidatorFn(control); | ||
| let libraryResult = combination.libraryValidatorFn(control); | ||
|
|
||
| libraryResult = libraryResult; |
There was a problem hiding this comment.
Makes me wonder if I was slightly drunk at the time 😀.
Update library to build on Angular 14.