Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update ts-node version. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2017
Merged

Update ts-node version. #5

merged 3 commits into from
Jul 4, 2017

Conversation

westy92
Copy link
Contributor

@westy92 westy92 commented Apr 10, 2017

Closes #3.

I don't see a CHANGELOG for ts-node, so I don't know if there are any breaking changes for the functionality we're using. There's no tests here, so I cannot verify my changes are valid.

@wzrdtales
Copy link
Member

@RemyJeancolas Can you have a look here?

RemyJeancolas
RemyJeancolas approved these changes Jul 3, 2017
View reviewed changes
Copy link
Collaborator

@RemyJeancolas RemyJeancolas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require('ts-node/register') is a shortcut that does exactly the same thing, and it's a good practice to use it 👍

@wzrdtales wzrdtales merged commit 021a4a4 into db-migrate:master Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemyJeancolas RemyJeancolas RemyJeancolas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westy92 @wzrdtales @RemyJeancolas