Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make the --ssl-capath CLI argument a directory#1588

Merged
rolandwalker merged 1 commit intomainfrom
RW/make-capath-cli-arg-a-path
Feb 20, 2026
Merged

Make the --ssl-capath CLI argument a directory#1588
rolandwalker merged 1 commit intomainfrom
RW/make-capath-cli-arg-a-path

Conversation

@rolandwalker
Copy link
Contributor

@rolandwalker rolandwalker commented Feb 20, 2026

Description

This influences the helpdoc, which now will show

--ssl-capath DIRECTORY

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran 
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Feb 20, 2026
@rolandwalker
make the --ssl-capath CLI argument a directory
5b219fc 
This influences the helpdoc, which now will show

    --ssl-capath DIRECTORY
@rolandwalker rolandwalker force-pushed the RW/make-capath-cli-arg-a-path branch from 2c38b00 to 5b219fc Compare February 20, 2026 11:54
@github-actions
Copy link

github-actions bot commented Feb 20, 2026

Findings
No correctness or security issues found in the change.

Missing Tests / Edge Cases

  1. Add a CLI test to assert --ssl-capath rejects files and non-existent paths and accepts existing directories. This prevents regressions in validation behavior. Reference: mycli/main.py:1666.

Notes

  • The help text showing DIRECTORY is consistent with Click’s directory type name.

If you want, I can draft the test.

scottnemes
scottnemes approved these changes Feb 20, 2026
View reviewed changes
Copy link
Contributor

@scottnemes scottnemes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the --ssl-capath arg only takes a dir and not a file

@rolandwalker rolandwalker merged commit 4a79274 into main Feb 20, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/make-capath-cli-arg-a-path branch February 20, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottnemes scottnemes scottnemes approved these changes

@amjith amjith Awaiting requested review from amjith

Assignees

@rolandwalker rolandwalker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rolandwalker @scottnemes