Findings

1. Potential prompt corruption + uncaught exceptions from browser launch
   webbrowser.open_new_tab() is invoked outside run_in_terminal and without error handling. If the browser command writes to stdout/stderr or raises (common on headless systems), this can corrupt the prompt or bubble exceptions into the key handler. Consider wrapping the browser call inside run_in_terminal and catching webbrowser.Error/OSError so F1 never destabilizes the UI.
   File: mycli/key_bindings.py:51 and mycli/key_bindings.py:58

Missing tests / edge cases

1. No coverage for the new F1 behavior
   There are no tests asserting that the F1 binding emits help text and attempts a browser open. A lightweight unit test could monkeypatch webbrowser.open_new_tab and prompt_toolkit.application.run_in_terminal to assert both are called, and that failures don’t raise.
   File: mycli/key_bindings.py:51 and mycli/key_bindings.py:58

If you want, I can sketch a minimal pytest for this.

Interesting! Does this command not work on your setup?

python -m webbrowser -t "https://www.python.org"

A try/except wouldn't help. The error output is coming from an external program. But I think the issue can be fixed by the same invalidation trick as in #1632 .

See if the pushed changes fix the spurious output for you by invalidating the display.

Interesting! Does this command not work on your setup?

python -m webbrowser -t "https://www.python.org"

A try/except wouldn't help. The error output is coming from an external program. But I think the issue can be fixed by the same invalidation trick as in #1632 .

I use WSL2 on Windows11 for most of my testing, so always a bit different. I am able to install packages to make it work to load the browser though, so verified that bit works.

However the error output is the same after your most recent change. But it looks fine in general, and I couldn't find any good way to suppress the error without getting hacky. So should be good as-is.

That's good to know. Maybe we could improve our Windows support, both in and out of WSL2. Maybe we could at least improve the documentation.