Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Show toolbar error messages in an error style#1639

Merged
rolandwalker merged 1 commit intomainfrom
RW/use-error-style-cli-toolbar
Feb 27, 2026
Merged

Show toolbar error messages in an error style#1639
rolandwalker merged 1 commit intomainfrom
RW/use-error-style-cli-toolbar

Conversation

@rolandwalker
Copy link
Contributor

Description

Trivial followup to #1629, covered in the existing changelog entry.

last image

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Feb 27, 2026
@github-actions
Copy link

No blocking findings in this PR’s change set (mycli/clitoolbar.py).

  1. test coverage gap at mycli/clitoolbar.py:46
    Add a unit test for create_toolbar_tokens_func() that asserts:
  • when toolbar_error_message is set, emitted token class is class:bottom-toolbar.transaction.failed
  • the message is consumed (toolbar_error_message reset to None) after rendering

This guards against accidental regression back to non-error styling and preserves current one-shot behavior.

Residual risk: low, limited to UI styling behavior only; no security concerns identified.

@rolandwalker rolandwalker force-pushed the RW/use-error-style-cli-toolbar branch from 3d0c42f to 65717a7 Compare February 27, 2026 11:05
@rolandwalker rolandwalker merged commit 9c2dfbf into main Feb 27, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/use-error-style-cli-toolbar branch February 27, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant