Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add environment variable section to --checkup#1644

Merged
rolandwalker merged 1 commit intomainfrom
RW/checkup-environment-section-2
Feb 28, 2026
Merged

Add environment variable section to --checkup#1644
rolandwalker merged 1 commit intomainfrom
RW/checkup-environment-section-2

Conversation

@rolandwalker
Copy link
Contributor

Description

Add environment variable section to --checkup, covering editor setup, and add $VISUAL example to TIPS.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@github-actions
Copy link

  1. Correctness (docs behavior mismatch)
    The new tip recommends export VISUAL=code, but \edit relies on click.edit(...) which waits for the editor process to exit; plain code typically returns immediately, so users can get stale/empty query text.

  2. Missing tests (new --checkup output path untested)
    The added environment-variable section in do_config_checkup has no test coverage, so regressions in wording/branching (set vs unset vars) won’t be caught.

    • New logic: mycli/main.py:2493
      Action: add a unit test for --checkup output that monkeypatches os.environ for EDITOR/VISUAL and asserts both “set” and “not set” messages.

No direct security issue stood out in this PR.

@rolandwalker rolandwalker force-pushed the RW/checkup-environment-section-2 branch from 00f65f2 to 6a6bb6e Compare February 27, 2026 11:35
@rolandwalker rolandwalker self-assigned this Feb 27, 2026
covering editor setup, and add $VISUAL example to TIPS
@rolandwalker rolandwalker force-pushed the RW/checkup-environment-section-2 branch from 6a6bb6e to e9ca660 Compare February 28, 2026 11:20
@rolandwalker rolandwalker merged commit 74ee77d into main Feb 28, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/checkup-environment-section-2 branch February 28, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants