Merge pull request laravel#908 from filp/improve/whoops-open-in-editor

taylorotwell · taylorotwell · commit 67af35f744cb · 2013-04-12T08:06:14.000-07:00
Implement Whoops feature to open referenced files in editor/IDE
diff --git a/composer.json b/composer.json
@@ -13,7 +13,7 @@
         "php": ">=5.3.7",
         "classpreloader/classpreloader": "1.0.*",
         "ircmaxell/password-compat": "1.0.*",
-        "filp/whoops": "1.0.0",
+        "filp/whoops": "1.0.1",
         "monolog/monolog": "1.4.*",
         "patchwork/utf8": "1.0.*",
         "predis/predis": "0.8.*",
diff --git a/src/Illuminate/Exception/composer.json b/src/Illuminate/Exception/composer.json
@@ -9,7 +9,7 @@
     ],
     "require": {
         "php": ">=5.3.0",
-        "filp/whoops": "1.0.0",
+        "filp/whoops": "1.0.1",
         "illuminate/support": "4.0.x",
         "symfony/http-foundation": "2.3.x",
         "symfony/http-kernel": "2.3.*"
diff --git a/src/Illuminate/Exception/resources/pretty-page.css b/src/Illuminate/Exception/resources/pretty-page.css
@@ -109,6 +109,17 @@ header {
       color:#999;
       word-wrap:break-word;
     }
+      .editor-link {
+        color: inherit;
+      }
+        .editor-link:hover strong {
+          color: #F0E5DF;
+        }
+
+        .editor-link-callout {
+          padding: 2px 4px;
+          background: #872D00;
+        }
 
     .frame-line {
       font-weight: bold;
diff --git a/src/Illuminate/Exception/resources/pretty-template.php b/src/Illuminate/Exception/resources/pretty-template.php
@@ -67,7 +67,14 @@
               <?php $line = $frame->getLine(); ?>
                 <div class="frame-code <?php echo ($i == 0 ) ? 'active' : '' ?>" id="frame-code-<?php echo $i ?>">
                   <div class="frame-file">
-                    <strong><?php echo $e($frame->getFile() ?: '<#unknown>') ?></strong>
+                    <?php $filePath = $frame->getFile(); ?>
+                    <?php if($filePath && $editorHref = $v->handler->getEditorHref($filePath, (int) $line)): ?>
+                      <a href="<?php echo $editorHref ?>" class="editor-link">
+                        <span class="editor-link-callout">open:</span> <strong><?php echo $e($filePath ?: '<#unknown>') ?></strong>
+                      </a>
+                    <?php else: ?>
+                      <strong><?php echo $e($filePath ?: '<#unknown>') ?></strong>
+                    <?php endif ?>
                   </div>
                   <?php
                     // Do nothing if there's no line to work off
