Implement Whoops feature to open referenced files in editor/IDE#908
Merged
Conversation
taylorotwell
added a commit
that referenced
this pull request
Apr 12, 2013
Implement Whoops feature to open referenced files in editor/IDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
filps/whoopsdependency to1.0.1, which includes among other small fixes a feature to enable opening files referenced in the error page in the user's editor/IDE of choice. Required changes to templates & CSS were also ported.Currently, the feature will not be visible, as no editor is set by default. I've decided against making the choice to structure that myself. My idea was to add another option to
app/config/app.phpnamededitoror some such, but there's probably room to allow machine-specific editor choices, loading from environment variables, etc.Setting an editor is simple:
PrettyPageHandlerPrettyPageHandler::setEditor( string $identifier )to set an editor by identifiersetEditorthat accepts a file path and a line number, and returns a string usable as anhrefpropertyPrettyPageHandler::addEditor(string $identifier, callable)Finally, @daylerees might want to have a look at my changes to the template and CSS, and tweak them to fit his choices - my solution is far from perfect 😅
Additional info is available in the whoops repo.
Cheers!