Update branch tags only when releases are made #38
Conversation
|
Needs quick rebase and review by @jonaseberle or @stasadev |
Also use https://github.com/tj-actions/release-tagger instead of our own custom workflow code.
6338e7b to
8ec8f19
Compare
There was a problem hiding this comment.
I don't think it worked as expected.
I created a fork, merged this branch into main, created a release. It failed, because it goes through each tag, checks for release for each tag to retrieve description.
(This repo has 6 releases and 22 tags - so adding tj-actions/release-tagger will require to have releases for all tags.)
After that fail, I removed all tags in my fork except v1.10.1 and v1, created a release for v1.10.1 (because forks don't copy any releases from parent repos), and tried to create a new release v1.10.2.
It worked, this action successfully added a new release for v1 tag, updated its description and marked it as the latest one.
But, I didn't see a moved tag for v1, it remained on the same git commit as v1.10.1.
| on: | ||
| release: | ||
| types: [published] |
There was a problem hiding this comment.
| on: | |
| release: | |
| types: [published] | |
| on: | |
| push: | |
| tags: | |
| - v* |
The Issue
The
v1tag that we have that is always updated should only really be updated when a new release is made, and not on every push to main.How This PR Solves The Issue
Updates the workflow to use https://github.com/tj-actions/release-tagger to update the
v1release. This also reduces our custom code.Manual Testing Instructions
None
Automated Testing Overview
None
Related Issue Link(s)
Release/Deployment Notes
None, this is an internal workflow change only.