PR for feedback #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use struct substitute std::tuple in compilation lists Use TR::FILE instead of std::FILE for IO Use of TR::Options instead of J9::Options for newly introduced options Use perror/TR_ASSERT to substitute fprint error message Revert extra newlines introduced Set all newly introduced options to be NOT_IN_SUBSET as they should work for all Use persistent allocator for global compilations list Fix possible multi-threading problem on compilation Number by using atomic addition Print method compiled and optimization level when dump Signed-off-by: Dedong Xie <[email protected]>
Remove commented code Signed-off-by: Dedong Xie <[email protected]>
Signed-off-by: Dedong Xie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.