Migrate to Webpacker #7464
Migrate to Webpacker #7464
Conversation
2344979 to
fb23e05
Compare
b4d8622 to
a34c32b
Compare
20757f6 to
00205aa
Compare
00205aa to
d501a9d
Compare
49cc732 to
eb40dcd
Compare
6c52fe1 to
3471555
Compare
ab25ff1 to
8fad38c
Compare
17ce54b to
8113753
Compare
8113753 to
9ae26c5
Compare
|
OMG all green! Thanks @beagleknight for your help |
| /** | ||
| * Arabic translation for foundation-datepicker | ||
| * Nico Mollet <[email protected]> | ||
| */ | ||
| ;(function($){ | ||
| $.fn.fdatepicker.dates['ar'] = { |
There was a problem hiding this comment.
@ferblape I see all these files have been removed, where are they now? I can't see them being moved... Thanks
There was a problem hiding this comment.
Ah, I see foundation-datepicker is added as a depndency in the package.json
|
Excellent job @ferblape, thank you so much! I left you a comment above regarding some translation files, could you check it out, please? Edit: I see it's marked as a dependency, all good! |
* develop: New Crowdin updates (#7850) Accessibility tool for development environments (#7810) Attempt to fix puffing-billy runtime error (#7853) Dynamically get all participatory space role tables for the `visible_meeting_for` query (#7855) Fix joining a meetings that the user already follows (#7854) Improve proposals import options (#7669) Fix proposal form attachment errors (#7856) New Crowdin updates (#7844) Fix branch name on generators (#7849) Conditionally render questions in election booth (#7822) Fix node version for version managers (#7848) Migrate to Webpacker (#7464)
|
@mrcasals @entantoencuanto @andreslucena this has been merged without any technical documentation? Or there's something that we haven't spot? |
|
hi @microstudi there's a second PR that hasn't been merged yet #7733 that includes documentation and a couple of guides to migrate apps and components. If you could check it and provide feedback in case you miss something I'd really appreciate it Thanks! |
|
Thanks @ferblape ! very helpful! |
🎩 What? Why?
This PR migrates javascripts from the old and beloved Asset Pipeline to they young and modern Webpacker
The migration has been divided in two PRs:
This migration doesn't include decidim-elections (see #7291 (comment))
This PR uses a beta version of Webpacker 6 gem, which is almost ready to be released and uses the modern Webpack v5. At the time of creating this PR that version hasn't been released yet.
The approach followed is that Decidim takes care of controlling Webpacker, so the applications using Decidim will rely on the Decidim Webpacker instance to compile the assets, this way we can manage all the dependencies in the package.json of Decidim.
Yarn has been introduced to manage frontend dependencies, and all the assets vendorized has been replaced by the npmjs version except those included in
decidim-core/app/packs/src/decidim/vendor:Development process
The development process is very smooth, in the root folder of Decidim the webpack-dev-server is available via
bin/webpack-dev-serverand the development_app is configured to use Decidim's Webpacker, so asset changes are detected and automatic reloading is enabled.Testing environment
Node has been added to all github workflows, together with a yarn install (using a cache folder to speedup) and it's necessary to precompile the assets before running the specs.
📌 Related Issues
Testing
You should create a new development_app, start webpack dev server and start browsing:
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
