Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Sep 11, 2025

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@sjrl sjrl requested a review from a team as a code owner September 11, 2025 06:24
@sjrl sjrl requested review from julian-risch and removed request for a team September 11, 2025 06:24
@sjrl sjrl self-assigned this Sep 11, 2025
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good to me already! Just two suggested changes and then the PR is ready to be merged.
Quick research led me to RUF043 being the breaking change. https://github.com/astral-sh/ruff/releases https://docs.astral.sh/ruff/rules/pytest-raises-ambiguous-pattern/

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@sjrl sjrl merged commit 491ecfd into main Sep 11, 2025
10 checks passed
@sjrl sjrl deleted the ruff-fix-cohere branch September 11, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants