DLPX-93823 cloud-init configuration contains module names that are no longer correct #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed3a1a0 to
af5abee
Compare
af5abee to
ba69444
Compare
ba69444 to
bf74b15
Compare
david-mendez1
approved these changes
Apr 1, 2025
jwk404
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few years ago, a cloud-init developer decided to rename all of the cloud-init
modules that had embedded hyphens in their name to replace those hyphens with
underscores. Our custom cloud-init configuration was never adjusted to account
for this.
This is also a good opportunity to verify what all of these modules do and validate
the list. If you're curious to know what each of these is supposed to do, they're
all documented at https://github.com/delphix/cloud-init/tree/develop/doc/module-docs (or https://docs.cloud-init.io/en/latest/reference/modules.html if you want a more user-friendly way to consume that).
Note that because we already configure cloud-init with
allow_userdata: false, none of thesemodules have access to any externally provided user data, which eliminates the
possibility of a cloud or hypervisor admin tampering with the Delphix configuration.
ab-pre-push: https://selfservice-jenkins.eng-tools-prd.aws.delphixcloud.com/job/appliance-build-orchestrator-pre-push/10695/