Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Glavin001
Copy link
Contributor

Automate usage of Fonts by Bootstrap and Font-Awesome. Fixes #164.

@fayimora, replaces Pull Request #173.

@addyosmani
Copy link
Member

Thanks for the squashed commit. This one is much cleaner 🏭

addyosmani added a commit that referenced this pull request Feb 5, 2014
Automate usage of Fonts by Bootstrap and Font-Awesome. Fixes #164.
@addyosmani addyosmani merged commit 2884528 into deprecate:master Feb 5, 2014
@fayimora
Copy link
Contributor

fayimora commented Feb 5, 2014

Thanks @Glavin001 We still need to wrap the new copy task with an if(compassBootstrap) block. Also, fontAwesome doesn't come with bootstrap so maybe we should take that out and put instructions in a wiki on how to add it.

What do you think @addyosmani ?

@Glavin001
Copy link
Contributor Author

You're both very welcome.


Adding instructions in the wiki for how to add external fonts, such as FontAwesome makes good sense. On an unrelated note, I also would like to add https://github.com/yeoman/generator-ember/issues/103#issuecomment-34032450 to the wiki.

I forgot that Bootstrap was optional in the installation.
Is the following how that should be accomplished in the template?

<% if (compassBootstrap) {%>
fonts: {
                files: [
                    { 
                        expand: true,
                        flatten: true,
                        filter: 'isFile',
                        cwd: '<%%= yeoman.app %>/bower_components/',
                        dest: '<%%= yeoman.app %>/styles/fonts/',
                        src: [ 
                            'bootstrap-sass/dist/fonts/**' // Bootstrap
                         ]
                    }
                ]
            },
<% } %>

@fayimora
Copy link
Contributor

fayimora commented Feb 5, 2014

@Glavin001 Yope that's correct!

@Glavin001
Copy link
Contributor Author

Bump to myself: reminder to do this.

I hope to have a moment to make a PR tonight.

TODO:

  • Remove FontAwesome

And make the code optional by checking compassBootstrap first.

Glavin001 added a commit to Glavin001/generator-ember that referenced this pull request Feb 13, 2014
Glavin001 added a commit to Glavin001/generator-ember that referenced this pull request Feb 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants