Updated TypeScript definitions and added tests#25
Closed
arusanov wants to merge 1 commit intodevelopit:masterfrom
Closed
Updated TypeScript definitions and added tests#25arusanov wants to merge 1 commit intodevelopit:masterfrom
arusanov wants to merge 1 commit intodevelopit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-redux
Almost 1-1 (only tests changed a little). Should be pretty easy to port newer version of typings.
Known Issue: (which is true for this also)
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-redux/index.d.ts#L14-L19
There is a known issue in TypeScript, which doesn't allow decorators to change the signature of the classes
they are decorating. Due to this, if you are using @connect() decorator in your code,
you will see a bunch of errors from TypeScript. The current workaround is to use connect() as a function call on
a separate line instead of as a decorator. Discussed in this github issue:
DefinitelyTyped/DefinitelyTyped#20796