Fix type definitions for connect#35
Closed
anion155 wants to merge 2 commits intodevelopit:masterfrom
anion155:patch-1
Closed
Fix type definitions for connect#35anion155 wants to merge 2 commits intodevelopit:masterfrom anion155:patch-1
anion155 wants to merge 2 commits intodevelopit:masterfrom
anion155:patch-1
Conversation
developit
reviewed
Dec 6, 2018
Owner
developit
left a comment
There was a problem hiding this comment.
Sorry for the slow review. I still haven't used TypeScript much so I'm not a great reviewer for definition changes.
|
|
||
| interface AdvancedComponentDecorator<TProps, TOwnProps> { | ||
| (component: AnyComponent<TProps, {}>): ComponentConstructor<TOwnProps, {}>; | ||
| (component: ComponentFactory<TProps>): ComponentConstructor<TOwnProps, {}>; |
Owner
There was a problem hiding this comment.
Would you be able to shed some light on what issue this solves?
Author
There was a problem hiding this comment.
AnyComponent is for Component instances and ComponentFactory for factories. At least it was like so, previously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.