fastapi-slim replaces fastapi#815
Merged
Merged
Conversation
See fastapi/fastapi#11522 for details
Member
|
such a shame, I don't really get why they decided to change this 😬 @n8sty thanks for the PR 🙏 |
vincentsarago
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I am changing
Replace the
fastapidependency withfastapi-slim.See fastapi/fastapi#11522 for details. My brief summary of what happened in the FastAPI project: Installing
fastapinow comes along with dependencies that are helpful for development and deployment, at the expense of installing more dependencies. Since tiler applications are opinionated in their dependencies additional dependencies raise the risk of conflicts, albeit slightly. This change keeps the same dependencies that FastAPI pulls in transitively.How I did it
Swap the dependency specification, meaning nothing would change 😄.
How you can test it
Unit tests, standard CI should be more than enough because this result in nothing changing.
Related Issues
N/A.