create a common entrypoint for base and udi, fix .config ownership for podman 5 #209
+58
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cgruver <[email protected]>
dkwon17
reviewed
Dec 18, 2024
dkwon17
approved these changes
Dec 18, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cgruver, dkwon17 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
Thank you @cgruver , I plan to squash and merge after verifying the PR locally |
dkwon17
added a commit
to dkwon17/devspaces-images
that referenced
this pull request
Dec 19, 2024
Fixes are from devfile/developer-images/pull/198 and devfile/developer-images/pull/209 Signed-off-by: David Kwon <[email protected]>
dkwon17
added a commit
to dkwon17/devspaces-images
that referenced
this pull request
Dec 19, 2024
Fixes are from devfile/developer-images/pull/198 and devfile/developer-images/pull/209 Signed-off-by: David Kwon <[email protected]>
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened to supersede of #208
This is a fix for - eclipse-che/che#23281
This also fixes the ownership of ~/.config to prevent podman 5+ errors
incorporate changes from 74af9a2