Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mloubout
Copy link
Contributor

@mloubout mloubout commented Aug 8, 2025

No description provided.

@mloubout mloubout added the misc label Aug 8, 2025
@mloubout mloubout force-pushed the modernize-string-formatting branch 3 times, most recently from 9429bb0 to dd43d3f Compare August 8, 2025 13:33
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 55.00000% with 18 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@cfc5a08). Learn more about missing BASE report.
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
devito/types/dense.py 45.45% 6 Missing ⚠️
devito/parameters.py 16.66% 5 Missing ⚠️
devito/types/dimension.py 55.55% 4 Missing ⚠️
devito/arch/compiler.py 0.00% 1 Missing ⚠️
devito/logger.py 0.00% 1 Missing ⚠️
devito/operator/profiling.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2706   +/-   ##
=======================================
  Coverage        ?   92.11%           
=======================================
  Files           ?      248           
  Lines           ?    49641           
  Branches        ?     4367           
=======================================
  Hits            ?    45726           
  Misses          ?     3208           
  Partials        ?      707           
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 71.07% <42.50%> (?)
pytest-gpu-nvc-nvidiaX 72.05% <42.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane from a quick glance

mloubout and others added 2 commits August 11, 2025 07:35
Modernize string formatting by replacing % operator with f-string syntax
across 12 core devito modules (61 total conversions). This improves
readability, performance, and follows current Python best practices.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Address line length (E501), indentation (E127), and syntax (E999)
issues introduced during the % to f-string conversion. Fixed f-string
syntax errors by extracting backslash expressions to variables.
All modified files now pass flake8 checks.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@mloubout mloubout force-pushed the modernize-string-formatting branch from dd43d3f to c8c2ccf Compare August 11, 2025 11:35
@mloubout mloubout merged commit b5d11ae into main Aug 11, 2025
36 checks passed
@mloubout mloubout deleted the modernize-string-formatting branch August 11, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants