Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@gurnec
Copy link
Contributor

@gurnec gurnec commented May 16, 2015

This PR attempts to close #86.

It simply places a dpkg hold on grub-pc in upgrade-system.sh to prevent its upgrade installation. This should be a fairly conservative approach.

Unfortunately, when grab-packages.sh tries to download grub-pc via apt-get install -q --reinstall -y -d grub-pc, apt-get fails due to the hold. It could remove the hold first (and that works today), but there's no guarantee that old packages will remain available in the archive, so the safer approach was to prevent any held packages from being downloaded., and given @Michagogo's correction below this would probably be just as good a solution, but instead it filters out grub-pc from the downloads. As it is now, this changes the manifest (for better or worse) to reflect that grub-pc isn't installed.

@devrandom
Copy link
Owner

This looks like a reasonable workaround, thank you.

devrandom pushed a commit that referenced this pull request May 16, 2015
prevent upgrade of grub-pc which can fail in lxc
@devrandom devrandom merged commit df8381b into devrandom:master May 16, 2015
@Michagogo
Copy link

Note that grub-pc wasn't being upgraded in that log. It's being newly installed, presumably pulled in by something else. I don't know if this solution is also relevant to this case.

@gurnec
Copy link
Contributor Author

gurnec commented May 16, 2015

@Michagogo You're right (at least for my setup, which is an Ubuntu 12.04 container running inside a 14.04 host). I somehow missed that it was being newly installed... however the hold is preventing its installation. Does this work for you?

@Michagogo
Copy link

Well, assuming it does work, then that's great (at least until something else goes wrong). I just can't test it right now, because I've temporarily worked around the issue by recreating the VM from scratch.

@Michagogo
Copy link

(I don't really know all that much about apt/dpkg, so I don't actually know what a "hold" is, etc...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure having to do with grub and upgrading

3 participants