windows are always sorted by windowLevel #138
Conversation
Coeur
commented
Jun 17, 2018
- windows are always sorted by windowLevel (it's in the doc)
- originalSubviews is private, so the object type is always UIView: no need to guard
- typo
windows are always sorted by windowLevel
Sources/ToastWindow.swift
Outdated
| self.bringWindowToTop() | ||
| for subview in self.originalSubviews.allObjects { | ||
| guard let subview = subview as? UIView else { continue } | ||
| for subview in self.originalSubviews.allObjects as! [UIView] { |
There was a problem hiding this comment.
I don't think it is good to use force casting. I'd like to avoid it when possible.
There was a problem hiding this comment.
But it makes sense here: it's a private variable, so we're 100% controlling its type.
It's the same dangerousness as calling myPrivateArray[2] when you already know that the count is 3 or higher.
There was a problem hiding this comment.
Anyway, I've re-introduced the guard and removed a call to bringWindowToTop.
|
@devxoul Hi, I'd like to include this improvement from your repository instead of my fork. Could we talk about it and see which parts are good and which parts need improvement? Thank you. |
|
@Coeur, I was at the army training center at that time due to my military service 😂 This improvement will be included today's release. Thanks for your great work! |