ldap_test: add filter tests#1249
Merged
Merged
Conversation
JoelSpeed
reviewed
Feb 2, 2019
Contributor
JoelSpeed
left a comment
There was a problem hiding this comment.
There's a conflict on this but other than that it looks sensible
The filters for user and group searches hadn't been included in our LDAP tests. Now they are. The concrete test cases are somewhat contrived, but that shouldn't matter too much. Also note that the example queries I've used are not supported in AD: https://stackoverflow.com/a/10043452 Signed-off-by: Stephan Renatus <[email protected]>
919e737 to
df18cb0
Compare
Contributor
Author
|
✔️ rebased |
JoelSpeed
approved these changes
Feb 3, 2019
Contributor
Author
|
@JoelSpeed Would you do me the honor of pushing the big green button? 😉 👇 |
Contributor
|
@srenatus Wasn't quite sure of the etiquette for merging 🙈 |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
ldap_test: add filter tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filters for user and group searches hadn't been included in our LDAP
tests. Now they are.
The concrete test cases are somewhat contrived, but that shouldn't
matter too much. Also note that the example queries I've used are not
supported in AD: https://stackoverflow.com/a/10043452