So, we're "patchy" for Name and LogoUrl -- empty-string means no update -- but not for Public? There is ways to do this in GRPC, so I wonder if we want to do that.

Concretely, if Public was of type BoolValue, we could differentiate "not provided" from "false". I suppose if we do that, we should do the same with the other fields; as you currently cannot

• unset trusted peers
• unset redirect URIs
• set the name to empty-string
• set the logoURL to empty-string

💭 I guess one could argue whether this is needed. But as it stands, you cannot update the client without setting its public value; that at least should be fixed IMHO

What would be your suggestion in this case? if it is a private client and the user tries to update to public we should return an error?

It seems that I need to use an external package in the proto file in order to get these types working.

import "google/protobuf/wrappers.proto";

Some details here: golang/protobuf#438

I can't get it working. If you have any suggestion how to make this working, I am up to it.

An alternative solution is to not update the Public field in the update operation.

I tried to address your concerns in the last commit. Please let me know if this solution is fine for you.

Yeah, I'm not sure how to best deal with this one. An alternative to introducing wrappers could be to use a FieldMask in UpdateClientReq. And of course, we could just leave it as-is. What do you think, @ericchiang?

Re 49fa5ee, I'm not sure I follow... From what I can tell, it's now an append-only operation? I.e. whatever is in the UpdateClientReq.RedirectUris will be added to old.RedirectUris; but nothing could ever get removed? I'm not sure if this really is what we want... I think something like

		if req.RedirectUris != nil {
			old.RedirectURIs = req.RedirectUris
		}

would do the trick -- it lets you determine what the RedirectUris are after the update, and it allows you to set them to []string{}. Before, what last thing wasn't possible (unless I'm mistaken). Likewise for TrustedClients.

Thanks for bearing with me here 😃

😄 This was what I understood from your first comment. I reverted the last commit, and also allow to update the redirect URIs and trusted peers to []string{}.

The Public filed update was removed as well. I think is not required to be updated after the initial registration.

Hope this is what you are expecting! Thanks

I think we should either just overwrite the public field with whatever was in the UpdateClientReq (what you had pushed before; sorry about that) -- and ensure that documentation makes it obvious that the behaviour isn't patchy when it comes to public; or keep the code as-is and remove the field from this message.

I would prefer to remove the public field since is not used. Please could you point me to the documentation, which should I update?

The filed is removed.