fix bogus conformance failure due to time zones#1344
Merged
srenatus merged 1 commit intoNov 16, 2018
Conversation
this failed on my machine due to the unexported 'loc' field of the time structure - it was nil in one and set to a ton of tiemzone data in the other. instead let's just compare the unix timestamp value and zero it out for the struct comparison.
srenatus
approved these changes
Nov 16, 2018
Contributor
srenatus
left a comment
There was a problem hiding this comment.
Thank you. Flaky tests are the worst. 👍
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
…-comparison fix bogus conformance failure due to time zones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this failed on my machine due to the unexported 'loc' field of the time structure - it was nil in one and set to a ton of timezone data in the other. not sure why, but I don't think it's critical to compare these hidden fields so long as the timestamp's actual value is equal.