Kubernetes docs: clarify steps around use/creation of TLS assets.#1358
Conversation
|
Got my issue numbers wrong, embarassing |
…ifest, remove some references to deprecated TPR approach
|
Thanks for the fast review! I've updated (sorry) with some of the follow-ups I mentioned above |
srenatus
left a comment
There was a problem hiding this comment.
No worries, thank you for improving this further! 😃
| rootCA: ca.crt | ||
| userSearch: | ||
| # Would translate to the query "(&(objectClass=person)(uid=<username>))". | ||
| # Would translate to the query "(&(objectClass=posixAccount)(uid=<username>))". |
|
Looks good to me. However, I have no idea if it's correct. Please bear with me, let's get someone with sufficient knowledge of the domain to review this. (If you know someone, feel free to pull them in, it doesn't have to be someone with "commit bit". I'll merge when this has been reviewed, then.) |
|
That sounds good to me, I'm not sure who to call on as this is all based on my own testing but I'd definitely appreciate a second set of eyes. |
|
@whereisaaron @rendhalver would this be something one of you could weigh in on at all? |
|
Nice work! |
|
Good update |
…etes-documentation-improvements Kubernetes docs: clarify steps around use/creation of TLS assets.
Related to issue #1262 .
While not strictly related to TLS, I'd like to make one or more follow-up PRs to fix issues around old references to TPRs, missing instructions on creating the serviceAccount and roles for RBAC etc. But this is a first pass, hopefully it makes reviewing easier.